Skip to content

Mark room as fully read when user goes back to the room list. #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

Mark room as fully read when user goes back to the room list. #2687

merged 3 commits into from
Jun 4, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 10, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Send m.fully_read read marker once the user is going back to the room list.
Second commit is just removing noise in the logs.

Motivation and context

Closes #2281

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner April 10, 2024 13:46
@bmarty bmarty requested review from ganfra and removed request for a team April 10, 2024 13:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bmarty bmarty changed the title Feature/bma/fully read Mark room as fully read when user goes back to the room list. Apr 10, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.40%. Comparing base (07af7cc) to head (ba1776c).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...features/messages/impl/timeline/MarkAsFullyRead.kt 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2687   +/-   ##
========================================
  Coverage    80.40%   80.40%           
========================================
  Files         2149     2150    +1     
  Lines        56843    56854   +11     
  Branches      7125     7127    +2     
========================================
+ Hits         45703    45713   +10     
- Misses        8689     8690    +1     
  Partials      2451     2451

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/cwjaq3

@frebib
Copy link
Contributor

frebib commented Apr 11, 2024

I'm running this patch and it doesn't seem to do anything for me

@ganfra
Copy link
Member

ganfra commented Apr 15, 2024

I'm running this patch and it doesn't seem to do anything for me

@bmarty I think the inner room can be closed before calling the method...

@bmarty
Copy link
Member Author

bmarty commented Apr 15, 2024

OK, closing this for now, we will revisit when the New divider in the timeline will be working as expected.

@bmarty bmarty closed this Apr 15, 2024
@manuroe manuroe mentioned this pull request Jul 4, 2024
Closed
@foss-
Copy link

foss- commented Dec 29, 2024

OK, closing this for now, we will revisit when the New divider in the timeline will be working as expected.

@bmarty Can you link the relevant open ticket for what's blocking this currently?

@bmarty bmarty reopened this Jun 4, 2025
@bmarty bmarty force-pushed the feature/bma/fullyRead branch from a1e8c21 to ae8abec Compare June 4, 2025 10:59
@bmarty bmarty added the PR-Bugfix For bug fix label Jun 4, 2025
@bmarty bmarty force-pushed the feature/bma/fullyRead branch from ae8abec to ba1776c Compare June 4, 2025 12:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bmarty bmarty merged commit 58d503f into develop Jun 4, 2025
29 of 31 checks passed
@bmarty bmarty deleted the feature/bma/fullyRead branch June 4, 2025 14:14
This was referenced Jun 9, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
PR-Bugfix For bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Own read marker (new) does not get updated when reading the room
4 participants
@bmarty @frebib @ganfra @foss-